Skip to content

Switch cfnlint to use api #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch cfnlint to use api #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions src/rpdk/core/fragment/lint_warning_printer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import json
import logging

import cfnlint.config
import cfnlint.core
from cfnlint import lint

from .module_fragment_reader import _get_fragment_file

Expand All @@ -27,11 +25,13 @@ def print_cfn_lint_warnings(fragment_dir):

def __get_cfn_lint_matches(fragment_dir):
filepath = _get_fragment_file(fragment_dir)

try:
try:
template = cfnlint.decode.cfn_json.load(filepath)
except json.decoder.JSONDecodeError:
template = cfnlint.decode.cfn_yaml.load(filepath)
with open(filepath, encoding="utf-8") as handle:
template = handle.read()
matches = lint(template, config={"regions": ["us-east-1"]})

return matches
except Exception as e: # pylint: disable=broad-except
LOG.error(
"Skipping cfn-lint validation due to an internal error.\n"
Expand All @@ -40,14 +40,3 @@ def __get_cfn_lint_matches(fragment_dir):
)
LOG.error(str(e))
return []

# Initialize the ruleset to be applied (no overrules, no excludes)
rules = cfnlint.core.get_rules([], [], [], [], False, [])

# Default region used by cfn-lint
regions = ["us-east-1"]

# Runs Warning and Error rules
matches = cfnlint.core.run_checks(filepath, template, rules, regions)

return matches