Persist auth in memory, removing loading credentials from SDK to supp…#117
Merged
Persist auth in memory, removing loading credentials from SDK to supp…#117
Conversation
satyakigh
force-pushed
the
auth-change
branch
2 times, most recently
from
70767e3 to
4daf145
Compare
kddejong
reviewed
Oct 22, 2025
kddejong
approved these changes
Oct 22, 2025
satyakigh
force-pushed
the
auth-change
branch
from
4daf145 to
82ca492
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Satyaki Ghosh (@satyakigh)
Status: Open
Changes: +105 additions, -172 deletions
Key Code Changes
In-Memory Credential Storage
• Removed dependency on AWS SDK credential loading (sdkIAMCredentials)
• Credentials are now stored directly in memory within AwsCredentials class
• IAM credentials stored as IamCredentials object with profile, region, and AWS credential identity
• Bearer credentials stored separately for SSO token support
Synchronous Credential Access
• Changed getIAM() from async to synchronous method
• Returns stored credentials directly instead of loading from SDK
• Throws error if credentials not configured (fail-fast approach)
• Added structuredClone() for immutable credential returns
Enhanced Type Safety
• IamCredentials now extends AwsCredentialIdentity with required profile and region fields
• Made profile and region required (not optional) in credential schema
• Added UpdateCredentialsResult type with success boolean
Simplified AWS Client
• Removed SettingsConfigurable implementation from AwsClient
• Eliminated async credential loading in client initialization
• CloudFormation and CloudControl clients now instantiated synchronously
• Region comes directly from stored credentials instead of settings subscription
Updated Request Handlers
• handleIamCredentialsUpdate() now returns boolean success status
• IAM credential update request returns UpdateCredentialsResult instead of void
• Improved error handling with explicit success/failure responses