Skip to content

Fix/Hover on GetAtt attributes shows proper information for logicalName and Attribute#118

Merged
satyakigh merged 6 commits intomainfrom
fix/hover-get-att
Oct 23, 2025
Merged

Fix/Hover on GetAtt attributes shows proper information for logicalName and Attribute#118
satyakigh merged 6 commits intomainfrom
fix/hover-get-att

Conversation

@deepfuriya
Copy link
Copy Markdown
Contributor

@deepfuriya deepfuriya commented Oct 22, 2025

Description of changes:

  • Hover on Fn::GetAtt: [ logicalNameOfResource, attributeName ] or !GetAtt logicalNameOfResource.attributeName will show a proper description for logicalName and attributeName
  • Added new YamlGetAttArray in LogicalIdReferneceFinder for GetAtt dot annotation type support.
  • Moved reusable function for GetAtt - hover and autocomplete to GetAttUtils

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@deepfuriya deepfuriya requested a review from a team as a code owner October 22, 2025 19:55
@Zee2413
Copy link
Copy Markdown
Contributor

Zee2413 commented Oct 23, 2025

It seems like the doc is different based on syntax. Can we bring consistency by using the cursor position when there is . operator by showing not-a-combined doc?

  • !GetAtt logicalNameOfResource.attributeName
  • Fn::GetAtt: [ logicalNameOfResource, attributeName ]

gemammercado
gemammercado previously approved these changes Oct 23, 2025
@satyakigh satyakigh merged commit 98b1485 into main Oct 23, 2025
8 checks passed
@satyakigh satyakigh deleted the fix/hover-get-att branch October 23, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants