Skip to content

improved duplicate code in hover, autocomplete, and pyodide#145

Merged
satyakigh merged 1 commit intomainfrom
fix/duplicate-code/hover-autocomplete-pyodide
Oct 29, 2025
Merged

improved duplicate code in hover, autocomplete, and pyodide#145
satyakigh merged 1 commit intomainfrom
fix/duplicate-code/hover-autocomplete-pyodide

Conversation

@tylerymarkowitz
Copy link
Contributor

  • improved duplicate code in in IntrinsicFunctionArgumentCompletionProvider, IntrinsicFunctionArgumentHoverProvider by pulling out shared functions into getattutils
  • improved duplicate code in pyodide-worker

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tylerymarkowitz tylerymarkowitz force-pushed the fix/duplicate-code/hover-autocomplete-pyodide branch from e72caae to 3c7ba51 Compare October 28, 2025 19:07
@tylerymarkowitz tylerymarkowitz marked this pull request as ready for review October 28, 2025 19:13
@tylerymarkowitz tylerymarkowitz requested a review from a team as a code owner October 28, 2025 19:13
@tylerymarkowitz
Copy link
Contributor Author

After this is merged I can enable code duplication check to be under a certain threshold as a requirement to merge

@tylerymarkowitz tylerymarkowitz force-pushed the fix/duplicate-code/hover-autocomplete-pyodide branch from 3c7ba51 to d50090d Compare October 29, 2025 16:25
@satyakigh satyakigh merged commit 410c9f0 into main Oct 29, 2025
10 checks passed
@satyakigh satyakigh deleted the fix/duplicate-code/hover-autocomplete-pyodide branch October 29, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants