Skip to content

Fix deletion workflow lsp request and pagination#147

Merged
kddejong merged 1 commit intomainfrom
fix/deletion-workflow
Oct 28, 2025
Merged

Fix deletion workflow lsp request and pagination#147
kddejong merged 1 commit intomainfrom
fix/deletion-workflow

Conversation

@chrisqm-dev
Copy link
Contributor

Description of changes:

  • We don't need to paginate the listChangeSets call because as soon as we get a nextToken there are at least two change sets (which means we should not remove the stack)
  • Was missing CfnServer Lsp requests as well

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chrisqm-dev chrisqm-dev marked this pull request as ready for review October 28, 2025 19:58
@chrisqm-dev chrisqm-dev requested a review from a team as a code owner October 28, 2025 19:58
@kddejong kddejong force-pushed the fix/deletion-workflow branch from b4f2f80 to ee6ee02 Compare October 28, 2025 20:33
@kddejong kddejong merged commit 1312bf0 into main Oct 28, 2025
8 checks passed
@kddejong kddejong deleted the fix/deletion-workflow branch October 28, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants