Skip to content

Conversation

@kddejong
Copy link
Collaborator

@kddejong kddejong commented Oct 3, 2025

Issue #, if available:

Description of changes:

  • Update Entity provider to only suggest on keys

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong requested a review from a team as a code owner October 3, 2025 15:19
@kddejong kddejong force-pushed the fix/autocomplete/entity/keysuggestions branch 2 times, most recently from f9cb844 to c6898c3 Compare October 3, 2025 15:26
Zee2413
Zee2413 previously approved these changes Oct 3, 2025
Copy link
Contributor

@Zee2413 Zee2413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case EntityFieldCompletionProvider ends up being the best spot for the conditional check.

@kddejong kddejong force-pushed the fix/autocomplete/entity/keysuggestions branch 2 times, most recently from 18da6b8 to 5059c3c Compare October 3, 2025 17:02
@kddejong
Copy link
Collaborator Author

kddejong commented Oct 3, 2025

Approving in case EntityFieldCompletionProvider ends up being the best spot for the conditional check.

I was able to update the atEntityKeyLevel to handle this. No changes to E2E tests and prevents weird autocomplete scenarios.

Zee2413
Zee2413 previously approved these changes Oct 3, 2025
@kddejong kddejong force-pushed the fix/autocomplete/entity/keysuggestions branch from 60b5e03 to 6aa4e17 Compare October 5, 2025 14:17
@github-actions
Copy link

github-actions bot commented Oct 5, 2025

Package Line Rate Branch Rate Complexity Health
ai 22% 80% 0
ai.llm 53% 80% 0
app 0% 0% 0
artifacts 100% 100% 0
auth 87% 92% 0
autocomplete 93% 91% 0
context 96% 96% 0
context.semantic 98% 97% 0
context.semantic.parameter 100% 95% 0
context.syntaxtree 89% 90% 0
context.syntaxtree.utils 86% 91% 0
datastore 77% 97% 0
definition 100% 100% 0
document 93% 96% 0
documentSymbol 93% 81% 0
handlers 75% 88% 0
hover 85% 86% 0
protocol 96% 100% 0
resourceState 76% 80% 0
schema 88% 87% 0
schema.transformers 85% 84% 0
server 97% 96% 0
services 67% 89% 0
services.cfnLint 72% 91% 0
services.guard 95% 79% 0
services.guard.assets 81% 77% 0
settings 97% 87% 0
stacks 100% 100% 0
telemetry 58% 78% 0
templates 89% 85% 0
utils 91% 92% 0
Summary 86% (16993 / 19682) 89% (3524 / 3957) 0

@kddejong kddejong force-pushed the fix/autocomplete/entity/keysuggestions branch from 6aa4e17 to a3ab873 Compare October 6, 2025 19:03
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Package Line Rate Branch Rate Complexity Health
ai 22% 80% 0
ai.llm 53% 80% 0
app 0% 0% 0
artifacts 100% 100% 0
auth 87% 92% 0
autocomplete 93% 91% 0
context 96% 96% 0
context.semantic 98% 97% 0
context.semantic.parameter 100% 95% 0
context.syntaxtree 89% 90% 0
context.syntaxtree.utils 86% 91% 0
datastore 77% 97% 0
definition 100% 100% 0
document 93% 96% 0
documentSymbol 93% 81% 0
handlers 75% 88% 0
hover 85% 86% 0
protocol 96% 100% 0
resourceState 76% 80% 0
schema 88% 87% 0
schema.transformers 87% 85% 0
server 97% 96% 0
services 67% 89% 0
services.cfnLint 72% 91% 0
services.guard 95% 79% 0
services.guard.assets 81% 77% 0
settings 97% 87% 0
stacks 100% 100% 0
telemetry 58% 78% 0
templates 89% 85% 0
utils 91% 92% 0
Summary 86% (17086 / 19779) 89% (3542 / 3976) 0

@Zee2413 Zee2413 force-pushed the fix/autocomplete/entity/keysuggestions branch from a3ab873 to cdfacac Compare October 7, 2025 17:55
@kddejong kddejong merged commit 44997fa into main Oct 7, 2025
8 checks passed
@kddejong kddejong deleted the fix/autocomplete/entity/keysuggestions branch October 7, 2025 18:17
gemammercado pushed a commit that referenced this pull request Oct 7, 2025
* Update Entity provider to only suggest on keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants