generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 1
Rename templates folder to stackActions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisqm-dev
commented
Sep 30, 2025
tylerymarkowitz
previously approved these changes
Sep 30, 2025
Zee2413
previously approved these changes
Oct 2, 2025
64c60bc
e1528d7 to
64c60bc
Compare
satyakigh
reviewed
Oct 6, 2025
satyakigh
reviewed
Oct 6, 2025
908b8a5 to
509a1d7
Compare
|
satyakigh
reviewed
Oct 7, 2025
8f912e2 to
fe8b88c
Compare
fe8b88c to
787086e
Compare
chrisqm-dev
commented
Oct 7, 2025
chrisqm-dev
commented
Oct 7, 2025
satyakigh
approved these changes
Oct 8, 2025
tylerymarkowitz
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Template" prefix for the templates/ folder will be renamed to "StackActions". The "LspStackHandler" which is used for listStacks is also renamed to "LspStackQueryHandler" to differentiate it from StackActions.
Files that were the source of refactors which need review
the other files were a result of refactoring with right click -> rename, you can quickly read over those changes
src/handlers/TemplateHandler -> StackHandler (existing file)
src/protocol/LspTemplateHandlers -> LspStackHandlers (merged with existing file)
src/templates/ -> src/stacks/actions
src/templates/TemplateOperations -> StackActionOperations
src/templates/TemplateRequestType -> StackActionProtocol and StackActionRequestType
src/templates/TemplateWorkflowType -> StackActionWorkflowType
src/templates/TemplateParser -> StackActionParser