Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9bee294
add Extract To Parameter code actions
Oct 3, 2025
fae6b4c
use existing intrinsic function list
Oct 3, 2025
988fe9f
fix import order
Oct 3, 2025
b05a611
defensive null/undefined handling
Oct 6, 2025
211e197
lint
Oct 6, 2025
a743ec4
Addressed comments
Oct 6, 2025
ad2e3f4
Merge branch 'main' into feature/extract-to-parameter-code-actions
atennak1 Oct 6, 2025
354ed94
Undo SytaxTree regex changes
Oct 7, 2025
b284264
Merge branch 'main' into feature/extract-to-parameter-code-actions
atennak1 Oct 7, 2025
5f0e8a8
Merge branch 'main' into feature/extract-to-parameter-code-actions
Oct 8, 2025
bf2fce4
Merge remote-tracking branch 'origin/main' into feature/extract-to-pa…
Oct 9, 2025
993a470
adapt detected indendation support
Oct 9, 2025
5e84710
handle null doc
Oct 9, 2025
6dc89d4
adapt detected indendation support
Oct 9, 2025
0d20d24
Merge branch 'main' into feature/extract-to-parameter-code-actions
atennak1 Oct 9, 2025
da4c7be
Fix JSON indentation and new parameter section placement
Oct 10, 2025
f6920d6
address ExtractToParameter.yaml.test.ts todos
Oct 10, 2025
210a1c4
Use preferred method for detected indentation
Oct 10, 2025
4a36bd6
Merge remote-tracking branch 'origin/main' into feature/extract-to-pa…
Oct 15, 2025
19ddee0
Merge remote-tracking branch 'origin/main' into feature/extract-to-pa…
Oct 15, 2025
59ae06a
remove unused components from CodeActionService
Oct 15, 2025
4711da4
lint
Oct 15, 2025
82a7df6
Merge branch 'main' into feature/extract-to-parameter-code-actions
atennak1 Oct 17, 2025
06956e4
Merge branch 'main' into feature/extract-to-parameter-code-actions
atennak1 Oct 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/services/CodeActionService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ export class CodeActionService {

const baseEditorSettings = this.settingsManager.getCurrentSettings().editor;
const doc = this.documentManager.get(params.textDocument.uri);
if (!doc) return [];
if (!doc) return undefined;
const docEditorSettings = doc.getEditorSettings(baseEditorSettings);

const extractionResult = this.extractToParameterProvider.generateExtraction(
Expand Down Expand Up @@ -619,12 +619,15 @@ export class CodeActionService {
return undefined;
}

const editorSettings = this.settingsManager.getCurrentSettings().editor;
const baseEditorSettings = this.settingsManager.getCurrentSettings().editor;
const doc = this.documentManager.get(params.textDocument.uri);
if (!doc) return undefined;
const docEditorSettings = doc.getEditorSettings(baseEditorSettings);

const extractionResult = this.extractToParameterProvider.generateAllOccurrencesExtraction(
context,
params.range,
editorSettings,
docEditorSettings,
params.textDocument.uri,
);

Expand Down
Loading