-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/indentation spacing issue #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements document-based indentation detection to override EditorSettings when auto-indentation is enabled in the IDE. The PR introduces an IndentationManager to centralize indentation handling and removes completion provider subscriptions, moving the indentation update logic to SettingsManager.
- Created
IndentationDetectionManagerfor document-specific indentation detection - Updated completion providers to use document-specific settings via
SettingsManager - Added new
detectIndentationsetting toEditorSettingswith default valuetrue
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/settings/IndentationDetectionManager.ts |
New module for detecting and caching document-specific indentation settings |
src/settings/SettingsManager.ts |
Enhanced to handle document-specific editor settings with indentation detection |
src/settings/Settings.ts |
Added detectIndentation boolean field to EditorSettings |
src/autocomplete/TopLevelSectionCompletionProvider.ts |
Removed settings subscription, now uses SettingsManager for document-specific indentation |
src/autocomplete/ResourceStateCompletionProvider.ts |
Updated to use document-specific settings from SettingsManager |
src/autocomplete/ResourceEntityCompletionProvider.ts |
Modified to get document-specific settings for snippet generation |
src/autocomplete/CompletionRouter.ts |
Updated to pass SettingsManager to providers and formatter |
src/autocomplete/CompletionFormatter.ts |
Removed settings subscription, now receives settings per formatting operation |
src/server/ServerComponents.ts |
Reordered initialization and removed direct completion provider references |
| Test files | Updated to include new detectIndentation setting and mock configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c603d64 to
bfe446a
Compare
|
bfe446a to
62b3125
Compare
…etection is enabled
98a9b6d to
c7a5a21
Compare
Description of changes:
EditorSettingsif customer hasauto-indentationsettings enabled in IDE.IndentationManagerwhich will handle all the indentation across the server.SettingsManagerwhich helps to update theindentationon server side whenever settings are updated.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.