Skip to content

Autocomplete nested objects bug fix #63

Merged
gemammercado merged 11 commits intomainfrom
nested-objects-fix
Oct 16, 2025
Merged

Autocomplete nested objects bug fix #63
gemammercado merged 11 commits intomainfrom
nested-objects-fix

Conversation

@gemammercado
Copy link
Contributor

@gemammercado gemammercado commented Oct 10, 2025

Currently autocomplete suggesting required keys only applies to properties. If cursor is nested in Resources -> Properties -> Object we also want to suggest properties for that object. This fix adds a check ifInNestedObject, if true, also use the ResourceSectionCompletionProvider

@gemammercado gemammercado requested a review from a team as a code owner October 10, 2025 15:59
@gemammercado gemammercado changed the title Autocomplete nested objects bug fix Autocomplete nested objects bug fix (clean) Oct 10, 2025
@Zee2413
Copy link
Contributor

Zee2413 commented Oct 10, 2025

no tests? unit or e2e update?

@gemammercado gemammercado changed the title Autocomplete nested objects bug fix (clean) Autocomplete nested objects bug fix Oct 14, 2025
satyakigh
satyakigh previously approved these changes Oct 14, 2025
Zee2413
Zee2413 previously approved these changes Oct 15, 2025
chrisqm-dev
chrisqm-dev previously approved these changes Oct 16, 2025
@gemammercado gemammercado dismissed stale reviews from chrisqm-dev and Zee2413 via 5ca09fa October 16, 2025 14:53
@gemammercado gemammercado removed the request for review from satyakigh October 16, 2025 14:55
Zee2413
Zee2413 previously approved these changes Oct 16, 2025
@gemammercado gemammercado merged commit da9955a into main Oct 16, 2025
8 checks passed
@gemammercado gemammercado deleted the nested-objects-fix branch October 16, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants