Skip to content

Commit ec609c8

Browse files
committed
Use ExportedName property of operation calls in ACK templates as well
Signed-off-by: Muvaffak Onus <[email protected]>
1 parent be27f16 commit ec609c8

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

templates/pkg/resource/sdk.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ func (rm *resourceManager) sdkCreate(
6363
{{ $hookCode }}
6464
{{- end }}
6565
{{ $createCode := GoCodeSetCreateOutput .CRD "resp" "ko" 1 false }}
66-
{{ if not ( Empty $createCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.Create.Name }}WithContext(ctx, input)
66+
{{ if not ( Empty $createCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.Create.ExportedName }}WithContext(ctx, input)
6767
{{- if $hookCode := Hook .CRD "sdk_create_post_request" }}
6868
{{ $hookCode }}
6969
{{- end }}
70-
rm.metrics.RecordAPICall("CREATE", "{{ .CRD.Ops.Create.Name }}", respErr)
70+
rm.metrics.RecordAPICall("CREATE", "{{ .CRD.Ops.Create.ExportedName }}", respErr)
7171
if respErr != nil {
7272
return nil, respErr
7373
}

templates/pkg/resource/sdk_find_get_attributes.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ func (rm *resourceManager) sdkFind(
2121
{{ $hookCode }}
2222
{{- end }}
2323
{{ $setCode := GoCodeGetAttributesSetOutput .CRD "resp" "ko" 1 }}
24-
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.GetAttributes.Name }}WithContext(ctx, input)
24+
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.GetAttributes.ExportedName }}WithContext(ctx, input)
2525
{{- if $hookCode := Hook .CRD "sdk_get_attributes_post_request" }}
2626
{{ $hookCode }}
2727
{{- end }}
28-
rm.metrics.RecordAPICall("GET_ATTRIBUTES", "{{ .CRD.Ops.GetAttributes.Name }}", respErr)
28+
rm.metrics.RecordAPICall("GET_ATTRIBUTES", "{{ .CRD.Ops.GetAttributes.ExportedName }}", respErr)
2929
if respErr != nil {
3030
if awsErr, ok := ackerr.AWSError(respErr); ok && awsErr.Code() == "{{ ResourceExceptionCode .CRD 404 }}" {{ GoCodeSetExceptionMessagePrefixCheck .CRD 404 }}{
3131
return nil, ackerr.NotFound

templates/pkg/resource/sdk_find_read_many.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ func (rm *resourceManager) sdkFind(
1414
{{ $hookCode }}
1515
{{- end }}
1616
{{ $setCode := GoCodeSetReadManyOutput .CRD "resp" "ko" 1 true }}
17-
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.ReadMany.Name }}WithContext(ctx, input)
17+
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.ReadMany.ExportedName }}WithContext(ctx, input)
1818
{{- if $hookCode := Hook .CRD "sdk_read_many_post_request" }}
1919
{{ $hookCode }}
2020
{{- end }}
21-
rm.metrics.RecordAPICall("READ_MANY", "{{ .CRD.Ops.ReadMany.Name }}", respErr)
21+
rm.metrics.RecordAPICall("READ_MANY", "{{ .CRD.Ops.ReadMany.ExportedName }}", respErr)
2222
if respErr != nil {
2323
if awsErr, ok := ackerr.AWSError(respErr); ok && awsErr.Code() == "{{ ResourceExceptionCode .CRD 404 }}" {{ GoCodeSetExceptionMessagePrefixCheck .CRD 404 }}{
2424
return nil, ackerr.NotFound

templates/pkg/resource/sdk_find_read_one.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ func (rm *resourceManager) sdkFind(
2121
{{ $hookCode }}
2222
{{- end }}
2323
{{ $setCode := GoCodeSetReadOneOutput .CRD "resp" "ko" 1 true }}
24-
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.ReadOne.Name }}WithContext(ctx, input)
24+
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.ReadOne.ExportedName }}WithContext(ctx, input)
2525
{{- if $hookCode := Hook .CRD "sdk_read_one_post_request" }}
2626
{{ $hookCode }}
2727
{{- end }}
28-
rm.metrics.RecordAPICall("READ_ONE", "{{ .CRD.Ops.ReadOne.Name }}", respErr)
28+
rm.metrics.RecordAPICall("READ_ONE", "{{ .CRD.Ops.ReadOne.ExportedName }}", respErr)
2929
if respErr != nil {
3030
if awsErr, ok := ackerr.AWSError(respErr); ok && awsErr.Code() == "{{ ResourceExceptionCode .CRD 404 }}" {{ GoCodeSetExceptionMessagePrefixCheck .CRD 404 }}{
3131
return nil, ackerr.NotFound

templates/pkg/resource/sdk_update.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ func (rm *resourceManager) sdkUpdate(
2424
{{ $hookCode }}
2525
{{- end }}
2626
{{ $setCode := GoCodeSetUpdateOutput .CRD "resp" "ko" 1 false }}
27-
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.Update.Name }}WithContext(ctx, input)
27+
{{ if not ( Empty $setCode ) }}resp{{ else }}_{{ end }}, respErr := rm.sdkapi.{{ .CRD.Ops.Update.ExportedName }}WithContext(ctx, input)
2828
{{- if $hookCode := Hook .CRD "sdk_update_post_request" }}
2929
{{ $hookCode }}
3030
{{- end }}
31-
rm.metrics.RecordAPICall("UPDATE", "{{ .CRD.Ops.Update.Name }}", respErr)
31+
rm.metrics.RecordAPICall("UPDATE", "{{ .CRD.Ops.Update.ExportedName }}", respErr)
3232
if respErr != nil {
3333
return nil, respErr
3434
}

templates/pkg/resource/sdk_update_set_attributes.go.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ func (rm *resourceManager) sdkUpdate(
2121
// contain any useful information. Instead, below, we'll be returning a
2222
// DeepCopy of the supplied desired state, which should be fine because
2323
// that desired state has been constructed from a call to GetAttributes...
24-
_, respErr := rm.sdkapi.{{ .CRD.Ops.SetAttributes.Name }}WithContext(ctx, input)
25-
rm.metrics.RecordAPICall("SET_ATTRIBUTES", "{{ .CRD.Ops.SetAttributes.Name }}", respErr)
24+
_, respErr := rm.sdkapi.{{ .CRD.Ops.SetAttributes.ExportedName }}WithContext(ctx, input)
25+
rm.metrics.RecordAPICall("SET_ATTRIBUTES", "{{ .CRD.Ops.SetAttributes.ExportedName }}", respErr)
2626
if respErr != nil {
2727
if awsErr, ok := ackerr.AWSError(respErr); ok && awsErr.Code() == "{{ ResourceExceptionCode .CRD 404 }}" {{ GoCodeSetExceptionMessagePrefixCheck .CRD 404 }}{
2828
// Technically, this means someone deleted the backend resource in

0 commit comments

Comments
 (0)