Skip to content

Add SAMLProvider to iam #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-07-22T22:04:27Z"
build_hash: b2dc0f44e0b08f041de14c3944a5cc005ba97c8f
build_date: "2025-08-13T20:33:51Z"
build_hash: dd7115d68c972714778e2bdd55a6f8b792494b97
go_version: go1.24.5
version: v0.50.0
api_directory_checksum: fcb205ac280ed1b0f107a291e5ea43d93c0991e9
version: v0.50.0-4-gdd7115d
api_directory_checksum: 6542a06695f8efcbc850caadb0383cc73ca9d712
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 9e30795ffa094ac7b68fe2bcb6913b0a2d7bccba
file_checksum: 9b330e4994e00d43b1672ac1dc7773e35e9fc432
original_file_name: generator.yaml
last_modification:
reason: API generation
56 changes: 27 additions & 29 deletions apis/v1alpha1/generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ignore:
#- Policy
- PolicyVersion
#- Role
- SAMLProvider
#- SAMLProvider
#- ServiceLinkedRole
- ServiceSpecificCredential
#- User
Expand Down Expand Up @@ -148,31 +148,7 @@ resources:
- InvalidInput
- MalformedPolicyDocument
fields:
# Left for historical purposes. It looks like late_initialize is was
# causing the controller to infinitely requeue (every 5 seconds) when the
# description was set to nil. Not it looks like this is not needed
# anymore.
# Note(a-hilaly): Very likely the API behavior has changed and the
# late_initialize is no longer needed.
#
Description:
# You might be wondering why description is late-initialized, since
# there isn't a default server-side value for description.
#
# The CreatePolicy API call accepts a Description field in the input
# and the documentation (and API model) say that a Description field is
# included in the returned response from CreatePolicy, however the
# Description returned from the CreatePolicy API call is always
# missing/nil which means the SetResource code sets the
# Spec.Description to nil. When the next time the GetPolicy API call is
# made in the next reconciliation loop, GetPolicy returns the
# description that was originally set in the CreatePolicy API call and
# a Delta difference is discovered erroneously (because the SetResource
# call after CreatePolicy incorrectly set the description to nil). So,
# we set the late initialize property of the Description field here to
# override the Spec.Description to the original value we set in the
# CreatePolicy *input* shape.
#late_initialize: {}
set:
- ignore: true
method: Create
Expand Down Expand Up @@ -221,13 +197,10 @@ resources:
set:
# The input and output shapes are different...
- from: PermissionsBoundary.PermissionsBoundaryArn
# Left for historical purposes.
Description:
set:
- ignore: true
method: Create
# See above in Policy resource about why this is here.
# late_initialize: {}
Path:
late_initialize: {}
# In order to support attaching zero or more policies to a role, we use
Expand Down Expand Up @@ -282,6 +255,31 @@ resources:
is_ignored: true
update_operation:
custom_method_name: customUpdateOpenIDConnectProvider
SAMLProvider:
hooks:
sdk_create_post_set_output:
template_path: hooks/saml_provider/sdk_create_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/saml_provider/sdk_update_pre_build_request.go.tpl
sdk_read_one_post_set_output:
template_path: hooks/saml_provider/sdk_read_one_post_set_output.go.tpl
exceptions:
errors:
404:
code: NoSuchEntityException
terminal_codes:
- InvalidInputException
- EntityAlreadyExistsException
fields:
SAMLProviderArn:
is_arn_primary_key: true
Name:
is_immutable: true
is_primary_key: true
CreateDate:
is_read_only: true
ValidUntil:
is_read_only: true
User:
hooks:
delta_pre_compare:
Expand Down Expand Up @@ -361,4 +359,4 @@ resources:
custom_method_name: customUpdateServiceLinkedRole
exceptions:
terminal_codes:
- InvalidInput
- InvalidInput
91 changes: 91 additions & 0 deletions apis/v1alpha1/saml_provider.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

126 changes: 126 additions & 0 deletions apis/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions cmd/controller/main.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/iam-controller
newTag: 1.4.4
newTag: 0.0.0-non-release-version
Loading