RDS Create DBInstance From Snapshot (#78)

Fixes aws-controllers-k8s/community#1262 

Description of changes:

This change is allow customer create db instance from DBSnapshotIdentifier when it's present. 

When DBSnapshotIdentifier is present in yaml file, ACK will try call [RestoreDBInstanceFromDBSnapshot](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceFromDBSnapshot.html#API_RestoreDBInstanceFromDBSnapshot) API instead of normal CreateDbInstance api. 

Tested this new behavior by adding `dbSnapshotIdentifier: "arn:aws:rds:us-west-2:980401675890:snapshot:brucegu-snapshot-1"` in yaml file and make sure DBInstance can be created from this snapshot. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: brucegucode

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-05-18T21:18:00Z"
+  build_date: "2022-05-27T02:20:26Z"
   build_hash: c651d2bb60694df1f7a5dad823258472a1a6fc8a
   go_version: go1.18.2
   version: v0.18.4-12-gc651d2b
-api_directory_checksum: 932f41dc8e3c84de66ba73cde9eecc2b94c847f3
+api_directory_checksum: 5e8e1929ea3e768826601ad5737bcf14bcfc4977
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: 6f5ece4103c904b1e0417e817cdc437743a85fb3
+  file_checksum: 18450c6db05caecfb0d53eec6fdbd80f3f0ce502
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/db_instance.go

@@ -131,6 +131,8 @@ resources:
           path: Parameters
   DBInstance:
     hooks:
+      sdk_create_pre_build_request:
+        template_path: hooks/db_instance/sdk_create_pre_build_request.go.tpl
       sdk_create_post_set_output:
         template_path: hooks/db_instance/sdk_create_post_set_output.go.tpl
       sdk_read_many_post_set_output:
@@ -145,6 +147,8 @@ resources:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
       delta_pre_compare:
         template_path: hooks/db_instance/delta_pre_compare.go.tpl
+      sdk_file_end:
+        template_path: hooks/db_instance/sdk_file_end.go.tpl
     exceptions:
       terminal_codes:
         - InvalidParameter
@@ -178,6 +182,14 @@ resources:
           resource: Key
           service_name: kms
           path: Status.ACKResourceMetadata.ARN
+      DBSnapshotIdentifier:
+        from:
+          operation: RestoreDBInstanceFromDBSnapshot
+          path: DBSnapshotIdentifier
+      UseDefaultProcessorFeatures:
+        from:
+          operation: RestoreDBInstanceFromDBSnapshot
+          path: UseDefaultProcessorFeatures
     renames:
       operations:
         CreateDBInstance:

apis/v1alpha1/generator.yaml

@@ -218,6 +218,13 @@ spec:
                 items:
                   type: string
                 type: array
+              dbSnapshotIdentifier:
+                description: "The identifier for the DB snapshot to restore from.
+                  \n Constraints: \n    * Must match the identifier of an existing
+                  DBSnapshot. \n    * If you are restoring from a shared manual DB
+                  snapshot, the DBSnapshotIdentifier    must be the ARN of the shared
+                  DB snapshot."
+                type: string
               dbSubnetGroupName:
                 description: "A DB subnet group to associate with this DB instance.
                   \n If there is no DB subnet group, then it is a non-VPC DB instance."
@@ -624,6 +631,11 @@ spec:
                 description: The time zone of the DB instance. The time zone parameter
                   is currently supported only by Microsoft SQL Server (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.TimeZone).
                 type: string
+              useDefaultProcessorFeatures:
+                description: "A value that indicates whether the DB instance class
+                  of the DB instance uses its default processor features. \n This
+                  setting doesn't apply to RDS Custom."
+                type: boolean
               vpcSecurityGroupIDs:
                 description: "A list of Amazon EC2 VPC security groups to associate
                   with this DB instance. \n Amazon Aurora \n Not applicable. The associated

apis/v1alpha1/zz_generated.deepcopy.go

@@ -131,6 +131,8 @@ resources:
           path: Parameters
   DBInstance:
     hooks:
+      sdk_create_pre_build_request:
+        template_path: hooks/db_instance/sdk_create_pre_build_request.go.tpl
       sdk_create_post_set_output:
         template_path: hooks/db_instance/sdk_create_post_set_output.go.tpl
       sdk_read_many_post_set_output:
@@ -145,6 +147,8 @@ resources:
         template_path: hooks/db_instance/sdk_delete_pre_build_request.go.tpl
       delta_pre_compare:
         template_path: hooks/db_instance/delta_pre_compare.go.tpl
+      sdk_file_end:
+        template_path: hooks/db_instance/sdk_file_end.go.tpl
     exceptions:
       terminal_codes:
         - InvalidParameter
@@ -178,6 +182,14 @@ resources:
           resource: Key
           service_name: kms
           path: Status.ACKResourceMetadata.ARN
+      DBSnapshotIdentifier:
+        from:
+          operation: RestoreDBInstanceFromDBSnapshot
+          path: DBSnapshotIdentifier
+      UseDefaultProcessorFeatures:
+        from:
+          operation: RestoreDBInstanceFromDBSnapshot
+          path: UseDefaultProcessorFeatures
     renames:
       operations:
         CreateDBInstance:

config/crd/bases/rds.services.k8s.aws_dbinstances.yaml

@@ -218,6 +218,13 @@ spec:
                 items:
                   type: string
                 type: array
+              dbSnapshotIdentifier:
+                description: "The identifier for the DB snapshot to restore from.
+                  \n Constraints: \n    * Must match the identifier of an existing
+                  DBSnapshot. \n    * If you are restoring from a shared manual DB
+                  snapshot, the DBSnapshotIdentifier    must be the ARN of the shared
+                  DB snapshot."
+                type: string
               dbSubnetGroupName:
                 description: "A DB subnet group to associate with this DB instance.
                   \n If there is no DB subnet group, then it is a non-VPC DB instance."
@@ -624,6 +631,11 @@ spec:
                 description: The time zone of the DB instance. The time zone parameter
                   is currently supported only by Microsoft SQL Server (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.TimeZone).
                 type: string
+              useDefaultProcessorFeatures:
+                description: "A value that indicates whether the DB instance class
+                  of the DB instance uses its default processor features. \n This
+                  setting doesn't apply to RDS Custom."
+                type: boolean
               vpcSecurityGroupIDs:
                 description: "A list of Amazon EC2 VPC security groups to associate
                   with this DB instance. \n Amazon Aurora \n Not applicable. The associated

generator.yaml

@@ -14,10 +14,14 @@
 package db_instance
 
 import (
+	"context"
 	"errors"
 	"fmt"
 
+	ackcondition "github.com/aws-controllers-k8s/runtime/pkg/condition"
 	ackrequeue "github.com/aws-controllers-k8s/runtime/pkg/requeue"
+	ackrtlog "github.com/aws-controllers-k8s/runtime/pkg/runtime/log"
+	corev1 "k8s.io/api/core/v1"
 )
 
 // NOTE(jaypipes): The below list is derived from looking at the RDS control
@@ -160,3 +164,33 @@ func instanceDeleting(r *resource) bool {
 	dbis := *r.ko.Status.DBInstanceStatus
 	return dbis == StatusDeleting
 }
+
+// function to create restoreDbInstanceFromDbSnapshot payload and call restoreDbInstanceFromDbSnapshot API
+func (rm *resourceManager) restoreDbInstanceFromDbSnapshot(
+	ctx context.Context,
+	r *resource,
+) (created *resource, err error) {
+	rlog := ackrtlog.FromContext(ctx)
+	exit := rlog.Trace("rm.restoreDbInstanceFromDbSnapshot")
+	defer func(err error) { exit(err) }(err)
+
+	resp, respErr := rm.sdkapi.RestoreDBInstanceFromDBSnapshotWithContext(ctx, rm.newRestoreDBInstanceFromDBSnapshotInput(r))
+	rm.metrics.RecordAPICall("CREATE", "RestoreDbInstanceFromDbSnapshot", respErr)
+	if respErr != nil {
+		return nil, respErr
+	}
+
+	rm.setResourceFromRestoreDBInstanceFromDBSnapshotOutput(r, resp)
+	rm.setStatusDefaults(r.ko)
+
+	// We expect the DB instance to be in 'creating' status since we just
+	// issued the call to create it, but I suppose it doesn't hurt to check
+	// here.
+	if instanceCreating(&resource{r.ko}) {
+		// Setting resource synced condition to false will trigger a requeue of
+		// the resource. No need to return a requeue error here.
+		ackcondition.SetSynced(&resource{r.ko}, corev1.ConditionFalse, nil, nil)
+		return &resource{r.ko}, nil
+	}
+	return &resource{r.ko}, nil
+}