Skip to content

Commit 48abf6c

Browse files
authored
Fix rename of DBParameterGroup family for AdoptedResource (#89)
Issue #, if available: aws-controllers-k8s/community#1264 Description of changes: issue-1264 was due to `DBParameterGroupFamily` is not renamed to` Family` for `DescribeDBParameterGroups` operation. Adding corresponding rename so AdoptedResource of db param group can work. basically create and read `DBParameterGroup`/`DBSubnetGroup` operations should have same rename strategy, hence align all of them here Previous error is: ``` 1.6553342486477876e+09 ERROR controller.adoptedresource Reconciler error {"reconciler group": "services.k8s.aws", "reconciler kind": "AdoptedResource", "name": "brucegu-ack-pg-1", "namespace": "default", "error": "DBParameterGroup.rds.services.k8s.aws \"brucegu-ack-pg-1\" is invalid: spec.family: Required value"} ``` After this update, no Reconciler error. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 712a5b9 commit 48abf6c

File tree

5 files changed

+25
-3
lines changed

5 files changed

+25
-3
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-06-15T18:55:14Z"
2+
build_date: "2022-06-15T23:33:58Z"
33
build_hash: 6acf40fe3e3cfd97b799ef7cbf1e89e01c3db8f7
44
go_version: go1.18.2
55
version: v0.18.4-15-g6acf40f
6-
api_directory_checksum: 4bdcfc19ab3ec6ae11525e6eb3a201e4a25b00fa
6+
api_directory_checksum: 7ded8dc716ff929b62e5d5b43a2c656a55f85985
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.42.0
99
generator_config_info:
10-
file_checksum: 3ff30261a7e6e7df5e498e37acf114f3c121173a
10+
file_checksum: 88ac4e4fff9ca9605e40c329178021face7472a8
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,18 @@ resources:
205205
DescribeDBParameterGroups:
206206
input_fields:
207207
DBParameterGroupName: Name
208+
DBParameterGroupFamily: Family
208209
CreateDBParameterGroup:
209210
input_fields:
210211
DBParameterGroupName: Name
211212
DBParameterGroupFamily: Family
212213
DeleteDBParameterGroup:
213214
input_fields:
214215
DBParameterGroupName: Name
216+
ModifyDBParameterGroup:
217+
input_fields:
218+
DBParameterGroupName: Name
219+
DBParameterGroupFamily: Family
215220
update_operation:
216221
# We need a custom update implementation until the issue behind
217222
# https://github.com/aws-controllers-k8s/community/issues/869 is
@@ -235,6 +240,7 @@ resources:
235240
DescribeDBSubnetGroups:
236241
input_fields:
237242
DBSubnetGroupName: Name
243+
DBSubnetGroupDescription: Description
238244
CreateDBSubnetGroup:
239245
input_fields:
240246
DBSubnetGroupName: Name

generator.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,18 @@ resources:
205205
DescribeDBParameterGroups:
206206
input_fields:
207207
DBParameterGroupName: Name
208+
DBParameterGroupFamily: Family
208209
CreateDBParameterGroup:
209210
input_fields:
210211
DBParameterGroupName: Name
211212
DBParameterGroupFamily: Family
212213
DeleteDBParameterGroup:
213214
input_fields:
214215
DBParameterGroupName: Name
216+
ModifyDBParameterGroup:
217+
input_fields:
218+
DBParameterGroupName: Name
219+
DBParameterGroupFamily: Family
215220
update_operation:
216221
# We need a custom update implementation until the issue behind
217222
# https://github.com/aws-controllers-k8s/community/issues/869 is
@@ -235,6 +240,7 @@ resources:
235240
DescribeDBSubnetGroups:
236241
input_fields:
237242
DBSubnetGroupName: Name
243+
DBSubnetGroupDescription: Description
238244
CreateDBSubnetGroup:
239245
input_fields:
240246
DBSubnetGroupName: Name

pkg/resource/db_parameter_group/sdk.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/db_subnet_group/sdk.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)