-
Notifications
You must be signed in to change notification settings - Fork 9
Improve support for wave port boundaries in a SolidModel #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works nicely! I have just a few changes suggested below. I also have a couple Palace questions:
- Is it possible to calculate port Q for wave ports?
- Is it OK to use a wave port with an absorbing boundary condition around it? Does the 2D solve just treat the 1D boundary as PEC (I see there's this issue awslabs/palace#265)?
…not perpendicular
95481b3 to
f60bc0d
Compare
Thanks for the feedback! I made changes in f60bc0d to address your comments and also added a warning when waveport transmission lines are not perpendicular to the domain boundary. Regarding your questions:
|
gpeairs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Improve support to define wave port boundaries in a
SolidModel:SolidModelTargetsnow takewave_port_layers, a list of layer symbols used to define wave port boundary conditionsLineSegmentin SolidModeladd_wave_ports!to automatically place wave port boundaries where paths/routes intersect the simulation area