Open
Conversation
gpeairs
force-pushed
the
gp/terminations
branch
2 times, most recently
from
d1bc317 to
a92dafd
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gpeairs
force-pushed
the
gp/terminations
branch
4 times, most recently
from
12836e7 to
7626b6d
Compare
gpeairs
force-pushed
the
gp/terminations
branch
2 times, most recently
from
0062265 to
a66a513
Compare
gpeairs
force-pushed
the
gp/terminations
branch
from
c35d023 to
610dfa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines #134 (PeriodicStyle), #136 (rounded trace tapers), and termination improvements; this is all one PR because they became entangled with a refactor to make everything compatible. I don't see a good way to break it back down.
Now we can split terminations and use them in periodic styles, overlay styles, and combinations of periodic and overlay styles. This took a bit of refactoring but I think it's not that complex in the end.
Closes #22 and #13.