Refactor connector configurations for type safety and consistency #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the `Embedder` type, which previously was empty. - Added predicate methods to `Enricher` for `isImage`, `isTable` and `isNER`; these are used for validating that only one of each type may be used in a set of Workflow nodes. - Added `TestWorkflowNodeOrder` to validate ~500 permutations of workflow node types and ordering. An empty workflow node list is now considered invalid, as a partitioner node must always appear in the list. - Consolidated all `<Foo>ConnectorConfigInput` types into `<Foo>ConnectorConfig`. - Consolidated `<Foo>SourceConnectorConfig` and `<Foo>DestinationConnectorConfig` types into `<Foo>ConnectorConfig` types for Couchbase, S3, GCS, Kafka Cloud, Postgres, Snowflake, and OneDrive. A few fields changed from values to pointers along the way. - ContextualChunkingStrategy removed from all chunking types, deafults to `"v1"` during JSON marshaling - `WorkflowType` is removed from `CreateWorkflowRequest` and instead defaults to `"custom"` during JSON marshaling. - Updated naming for Go-style PascalCase with uppercased acronyms (`Gcs` -> `GCS`, `Ibm` -> `IBM`); also fixed `Onedrive` -> `OneDrive`. - Fixed copyright year in LICENSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embeddertype, which previously was empty.EnricherforisImage,isTableandisNER; these are used for validating that only one of each type may be used in a set of Workflow nodes.TestWorkflowNodeOrderto validate ~500 permutations of workflow node types and ordering. An empty workflow node list is now considered invalid, as a partitioner node must always appear in the list.<Foo>ConnectorConfigInputtypes into<Foo>ConnectorConfig.<Foo>SourceConnectorConfigand<Foo>DestinationConnectorConfigtypes into<Foo>ConnectorConfigtypes for Couchbase, S3, GCS, Kafka Cloud, Postgres, Snowflake, and OneDrive. A few fields changed from values to pointers along the way."v1"during JSON marshalingWorkflowTypeis removed fromCreateWorkflowRequestand instead defaults to"custom"during JSON marshaling.Gcs->GCS,Ibm->IBM); also fixedOnedrive->OneDrive.