Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MikeDombo
reviewed
Mar 11, 2025
| kernel.orderedDependencies().stream().filter(GreengrassService::shouldAutoStart) | ||
| .filter(o -> !kernel.getMain().equals(o)).collect(Collectors.toList()); | ||
| Set<GreengrassService> nonAutoStartableServices = kernel.orderedDependencies().stream() | ||
| .filter(service -> !service.shouldAutoStart()).collect(Collectors.toSet()); |
Member
There was a problem hiding this comment.
this would probably be better to put on GreengrassService as allDependenciesAutoStart or something like that.
Member
Author
There was a problem hiding this comment.
Updated it to kernel since it directly finds specific services from all services
|
Binary incompatibility detected for commit 46189bc. com.aws.greengrass.lifecyclemanager.KernelAlternatives is binary incompatible and is source incompatible because of METHOD_LESS_ACCESSIBLE Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 46189bc |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 46189bc |
| for (GreengrassService depender : currentService.getHardDependers()) { | ||
| // Ensure dependers haven't been processed | ||
| if (initialServices.add(depender)) { | ||
| dependers.offer(depender); |
Check notice
Code scanning / CodeQL
Ignored error status of call Note
robcmann
approved these changes
Mar 21, 2025
saranyailla
approved these changes
Mar 24, 2025
saranyailla
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rd dependencies
Issue #, if available:
Right now, Nucleus (main service) is waiting for unpinned lambda (not auto startable components) lifecycle to be triggered and reach the terminal state for fss to send component status change message. This is due to all services are hard dependency of main and fss will wait until all services, including main, to reach their terminal state to send component status change message
Description of changes:
The new waiting strategy is: Nucleus exclude waiting for non autostartable components and any components have a hard dependencies of non autostartable components
This logic applies to both 1) when all deployments going on, bootstrap and default. 2) when fss sending component status change message
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.