fix: we skip download if the same version of nucleus is being deployed#1717
Merged
thomas-roos merged 2 commits intoaws-greengrass:mainfrom Jun 18, 2025
Merged
Conversation
During installation the gg nucleus zip is not copied into the artifacts dir, as the installer is contained in the zip file. Even if the zip file is copied, it does not match the expected checksum, as there is some code signature added in the zip file provided by the zip file coming from cloudfront. This is now using the version that is provided by the localCandidate.getVersion() function to determine if a download is necessary. So the nucleus component is treated special. Signed-off-by: Thomas Roos <throos@amazon.de>
thomas-roos
force-pushed
the
2025-06-03_main_installer
branch
from
f1261cc to
e3d1e57
Compare
|
Binary incompatibility detected for commit 7d51433. com.aws.greengrass.lifecyclemanager.KernelAlternatives is binary incompatible and is source incompatible because of METHOD_LESS_ACCESSIBLE Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7d51433 |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7d51433 |
alter-mage
previously approved these changes
Jun 16, 2025
Member
alter-mage
left a comment
alter-mage
left a comment
There was a problem hiding this comment.
The PR looks good to me. I made some logging improvements but that's just nit.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alter-mage
force-pushed
the
2025-06-03_main_installer
branch
from
2a48329 to
b7be83e
Compare
alter-mage
force-pushed
the
2025-06-03_main_installer
branch
from
b7be83e to
7d51433
Compare
alter-mage
approved these changes
Jun 16, 2025
yitingb
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
During installation the gg nucleus zip is not copied into the artifacts dir, as the installer is contained in the zip file. Even if the zip file is copied, it does not match the expected checksum, as there is some code signature added in the zip file provided by the zip file coming from cloudfront.
This is now using the version that is provided by the localCandidate.getVersion() function to determine if a download is necessary.
So the nucleus component is treated special.
Why is this change necessary:
As not necessary downloads should be avoided.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.