Conversation
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
|
Binary incompatibility detected for commit d77843f. com.aws.greengrass.componentmanager.KernelConfigResolver is binary incompatible and is source incompatible because of METHOD_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against d77843f |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against d77843f |
src/test/java/com/aws/greengrass/componentmanager/ComponentManagerCleanupTest.java
Outdated
Show resolved
Hide resolved
78fdfac to
deef693
Compare
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
0e7220a to
ef28ce4
Compare
src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java
Outdated
Show resolved
Hide resolved
ef28ce4 to
a113d08
Compare
...tests/java/com/aws/greengrass/integrationtests/deployment/DeploymentTaskIntegrationTest.java
Outdated
Show resolved
Hide resolved
a113d08 to
3d456fb
Compare
src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/lifecyclemanager/UpdateSystemPolicyService.java
Outdated
Show resolved
Hide resolved
846b442
846b442 to
b532aab
Compare
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/componentmanager/ComponentManager.java
Outdated
Show resolved
Hide resolved
b532aab to
f2b2baf
Compare
f2b2baf to
d77843f
Compare
Issue #, if available:
Description of changes:
Fix: Clean up deployment artifact logic to keep 2 successful deployments + 1 failed deployment artifacts.
minor fix: Account for possible null recheckTime.
Why is this change necessary:
Upon consecutive failed deployments, failed artifacts could accumulate indefinitely.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.