fix: assume processes have not stopped if we can't check their status#1755
fix: assume processes have not stopped if we can't check their status#1755aws-kevinrickard merged 1 commit intomainfrom
Conversation
f3947a0 to
bc65481
Compare
|
Binary incompatibility detected for commit ae45303. com.aws.greengrass.tes.CredentialRequestHandler is binary incompatible and is source incompatible because of FIELD_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against ae45303 |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against ae45303 |
bc65481 to
460a692
Compare
460a692 to
ae45303
Compare
Issue #, if available:
V1980934725
Description of changes:
Changed exception handling to return true (process is alive) when status checks fail, allowing further cleanup attempts.
Why is this change necessary:
When checking if processes are alive, IOException and InterruptedException were caught and ignored, causing the method to return false (process is dead) by default. This could in theory leave dangling processes behind because further cleanup attempts would not happen.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.