refactor: change the tes topic names to be more user-friendly#1758
Merged
junfuchen99 merged 1 commit intomainfrom Dec 23, 2025
Merged
refactor: change the tes topic names to be more user-friendly#1758junfuchen99 merged 1 commit intomainfrom
junfuchen99 merged 1 commit intomainfrom
Conversation
|
Binary incompatibility detected for commit 8622cbe. com.aws.greengrass.tes.CredentialRequestHandler is binary incompatible and is source incompatible because of FIELD_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8622cbe |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8622cbe |
junfuchen99
approved these changes
Dec 23, 2025
aws-kevinrickard
approved these changes
Dec 23, 2025
Member
aws-kevinrickard
left a comment
aws-kevinrickard
left a comment
There was a problem hiding this comment.
Approving cause we don't have strong config style standards already, and may want to try to release fast, but I think we should take another look at this (see comment)
| public static final String CLOUD_4XX_ERROR_CACHE_TOPIC = "error4xxCredentialRetryInSec"; | ||
| public static final String CLOUD_5XX_ERROR_CACHE_TOPIC = "error5xxCredentialRetryInSec"; | ||
| public static final String UNKNOWN_ERROR_CACHE_TOPIC = "errorUnknownCredentialRetryInSec"; | ||
| public static final String CREDENTIAL_RETRY_CONFIG_TOPIC = "credentialRetryInSec"; |
Member
There was a problem hiding this comment.
Looking at this now, it should probably be credentialRetryDelaySeconds , to reduce ambiguity from other retry concepts which can also be measured in time such as jitter or timeouts.
And optionally dropping the In as we usually just list the unit (see other configs such as sessionExpirySeconds, although there are some other configs which do use In like InBytes, we don't appear to have a consistent standard one way or the other)
Member
There was a problem hiding this comment.
Or maybe credentialRequestErrorCacheSeconds would be more appropriate
junfuchen99
pushed a commit
that referenced
this pull request
Dec 23, 2025
(cherry picked from commit 22edc62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
change the TES topic names to be more user-friendly and customer friendly
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.