refactor!: Remove metrics-server, efs and cloudwatch#445
Closed
askulkarni2 wants to merge 2 commits intomainfrom
Closed
refactor!: Remove metrics-server, efs and cloudwatch#445askulkarni2 wants to merge 2 commits intomainfrom
askulkarni2 wants to merge 2 commits intomainfrom
Conversation
askulkarni2
changed the title
|
Metrics server is not currently available in AWS GovCloud as an EKS add-on. With this change, GovCloud users would not be able to install metrics-server with this module (though it could still be installed as a generic Helm release). |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Pull request closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Removes metrics-server, efs and cloudwatch from the module as it is now available to be deployed via EKS add-ons.
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes