docs: Fix broken link for terraform install #2141
Conversation
.github/workflows/linkcheck.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "pattern": "https://developer.hashicorp.com/terraform/tutorials/terraform/install-cli" |
There was a problem hiding this comment.
Is this link correct? Just to make sure.
Co-authored-by: Rodrigo Bersa <[email protected]>
| ] | ||
| }, | ||
| { | ||
| "pattern": "https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli" |
There was a problem hiding this comment.
not sure if its intentional, but adding this here means that if this link 404s in the future, it won't get flagged by the link check
There was a problem hiding this comment.
That was my question on this file. This is required to be a not-found link, correct @bryantbiggs ?
There was a problem hiding this comment.
I'm saying, I don't think this should be added to the ignored patterns because if this link does die in the future, it won't get flagged by the link checker. I believe we do want the link to be checked and for the CI to error if the link 404s
There was a problem hiding this comment.
This is need it to avoid 429 errors even with retries
Run find docs -name "*.md" | xargs -n 1 markdown-link-check -q -c .github/workflows/linkcheck.json
find docs -name "*.md" | xargs -n 1 markdown-link-check -q -c .github/workflows/linkcheck.json
shell: /usr/bin/bash -e {0}
ERROR: 1 dead links found in docs/getting-started.md !
[✖] https://developer.hashicorp.com/terraform/tutorials/aws-get-started/install-cli → Status: 429
Error: Process completed with exit code 123.
Description
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes