Enable ECS end to end test for Java and Python #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Sep 12, 2024
validator/src/main/java/com/amazon/aoc/validators/TraceValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/services/XRayService.java
Outdated
Show resolved
Hide resolved
bjrara
approved these changes
Sep 13, 2024
validator/src/main/java/com/amazon/aoc/services/XRayService.java
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/ecs/hc-trace.mustache
Outdated
Show resolved
Hide resolved
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
force-pushed
the
ecs-no-call-zzhlogin
branch
from
6c96df5 to
1e36f50
Compare
# This is the 1st commit message: Test concurency. # The commit message #2 will be skipped: # Dummy commit # The commit message #3 will be skipped: # Dummy commit # The commit message #4 will be skipped: # Dummy commit # The commit message #5 will be skipped: # Dummy commit # The commit message #6 will be skipped: # add push. # The commit message #7 will be skipped: # Dummy commit # The commit message #8 will be skipped: # Dummy commit # The commit message #9 will be skipped: # Dummy commit # The commit message #10 will be skipped: # Add push condition. # The commit message #11 will be skipped: # Dummy commit
zzhlogin
force-pushed
the
ecs-no-call-zzhlogin
branch
from
2342b7c to
2c6acd4
Compare
majanjua-amzn
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Description of changes:
This PR enabled ECS end to end test for Java and Python including workflows, terraform and validation setups. The change follows same procedure for other platform: EC2, EKS and K8S.
Rollback procedure:
Revert this commit. No further revert action needed.
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
Example of successful workflows running:
Java: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10906916872
Python: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10906916891/job/30269312152
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.