Update Helm Chart Installation to download from latest release #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
Sep 10, 2024
majanjua-amzn
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
We need to download Helm Charts from the latest release instead of using the main branch
Description of changes:
Update code to query for the latest release in
https://api.github.com/repos/aws-observability/helm-charts/releases/latestUnauthenticated Github API request limit are 60/hour. Personal API request limit is 5000/hour. Not sure which one we are using but both options should be safe
Rollback procedure:
Revert Code
Test Run
https://github.com/harrryr/aws-application-signals-test-framework/actions/runs/10785901713
https://github.com/harrryr/aws-application-signals-test-framework/actions/runs/10785837052
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.