Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
The last time when we revert this commit was a wrong decision. We reverted due E2E EKS canary for Java failed for 12 hours and this was the most recent change, although it was running without any problems for 10+ hours. Revert of this commit didn’t fix the problem, a further investigation confirmed that the root cause was string interpolation in terraform template due to the password contains
$$.The log validator change has to be bundled with mysql version change because the newer mysql client introduce additional client side telemetry, we rely on the filter to test what we expected.
Description of changes:
Re-apply PR 221: #221
We need to run SampleApp Java ECR workflow once this PR is merged to pick up the SampleApp changes.
Rollback procedure:
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Yes. Re-ran SampleApp Java ECR workflow is required after revert.
Ensure you've run the following tests on your changes and include the link below:
Test run: https://github.com/jerry-shao/aws-application-signals-test-framework/actions/runs/10999688072/job/30540413745
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.