Skip to content

Conversation

@jerry-shao
Copy link
Contributor

@jerry-shao jerry-shao commented Sep 23, 2024

Issue description:

The last time when we revert this commit was a wrong decision. We reverted due E2E EKS canary for Java failed for 12 hours and this was the most recent change, although it was running without any problems for 10+ hours. Revert of this commit didn’t fix the problem, a further investigation confirmed that the root cause was string interpolation in terraform template due to the password contains $$.

The log validator change has to be bundled with mysql version change because the newer mysql client introduce additional client side telemetry, we rely on the filter to test what we expected.

Description of changes:
Re-apply PR 221: #221

We need to run SampleApp Java ECR workflow once this PR is merged to pick up the SampleApp changes.

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Yes. Re-ran SampleApp Java ECR workflow is required after revert.

Ensure you've run the following tests on your changes and include the link below:

Test run: https://github.com/jerry-shao/aws-application-signals-test-framework/actions/runs/10999688072/job/30540413745

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@majanjua-amzn majanjua-amzn merged commit aef00ab into aws-observability:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants