Update validators for E2E runtime metrics #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
force-pushed
the
main
branch
3 times, most recently
from
e9e33c6 to
1c2bbe5
Compare
bjrara
changed the title
There was a problem hiding this comment.
Definitely need to run this against some of our existing canaries/release tests. We can't merge this unless we're 100% sure it will not break our log and metric validation.
Unit tests don't provide enough confidence here, even if they have good coverage, since the real data has many different metric aggregations that can be impacted differently.
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Add E2E canaries for runtime metrics in Java and Python across platforms.
Description of changes:
ANY_VALUEmetric dimension value.Rollback procedure:
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.