Skip to content

Conversation

@bjrara
Copy link
Member

@bjrara bjrara commented Oct 9, 2024

Issue description:

Description of changes:

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:

@bjrara bjrara changed the title Add runtime metrics E2E test cases [DO NOT MERGE] Add runtime metrics E2E test cases Oct 9, 2024
@bjrara bjrara force-pushed the runtime branch 4 times, most recently from 092095b to 5f5bc0c Compare October 15, 2024 16:22
bjrara added a commit that referenced this pull request Oct 28, 2024
*Issue description:*
Runtime metrics will be enabled by default, and will be accepted as
valid Application Signals metrics by CloudWatch agent in the next
releases. As soon as the new artifacts are released, the canaries will
start failing because more metrics than (the current) expected will be
returned. This PR disables runtime metrics for now in the canaries
before
#283
is merged.

*Description of changes:*

*Rollback procedure:*

<Can we safely revert this commit if needed? If not, detail what must be
done to safely revert and why it is needed.>

*Ensure you've run the following tests on your changes and include the
link below:*

To do so, create a `test.yml` file with `name: Test` and workflow
description to test your changes, then remove the file for your PR. Link
your test run in your PR description. This process is a short term
solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL.
See the
[needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds)
keyword to run tests in succession.
- Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and
eu-central-2
- Run EC2 tests in all regions
- Run K8s on a separate K8s cluster (check IAD test account for master
node endpoints; these will change as we create and destroy clusters for
OS patching)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Co-authored-by: Harry <[email protected]>
@bjrara
Copy link
Member Author

bjrara commented Nov 22, 2024

Close in favor of #326.

@bjrara bjrara closed this Nov 22, 2024
@bjrara bjrara changed the title [DO NOT MERGE] Add runtime metrics E2E test cases Add runtime metrics E2E test cases Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant