Skip to content

fix lambda canary workflow #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix lambda canary workflow #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/node-lambda-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ jobs:
run: echo ARTIFACTS_DIR="${{ github.workspace }}/lambda_artifacts" >> $GITHUB_ENV

- name: Download Lambda Layer and Function artifacts for E2E Test
if: ${{ github.event.inputs.CALLER_WORKFLOW_NAME != 'appsignals-node-e2e-lambda-canary-test' }}
if: ${{ env.CALLER_WORKFLOW_NAME != 'appsignals-node-e2e-lambda-canary-test' }}
run: |
aws s3 cp s3://${{ env.STAGING_S3_BUCKET }}/layer-${{ github.run_id }}.zip ${{ env.ARTIFACTS_DIR }}/layer.zip |
aws s3 cp s3://${{ env.STAGING_S3_BUCKET }}/function-${{ github.run_id }}.zip ${{ env.ARTIFACTS_DIR }}/jsfunction.zip

- name: Set Canary Environment Variable
if: ${{ github.event.inputs.CALLER_WORKFLOW_NAME == 'appsignals-node-e2e-lambda-canary-test' }}
if: ${{ env.CALLER_WORKFLOW_NAME == 'appsignals-node-e2e-lambda-canary-test' }}
run: |
echo IS_CANARY=true >> $GITHUB_ENV |
aws s3 cp {{ env.SAMPLE_APP_ZIP }} ${{ env.ARTIFACTS_DIR }}/jsfunction.zip
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/python-lambda-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- uses: actions/checkout@v4
with:
repository: 'aws-observability/aws-application-signals-test-framework'
ref: ${{ inputs.caller-workflow-name == 'main-build' && 'main' || github.ref }}
ref: ${{ env.CALLER_WORKFLOW_NAME == 'main-build' && 'main' || github.ref }}
fetch-depth: 0

# We initialize Gradlew Daemon early on during the workflow because sometimes initialization
Expand Down Expand Up @@ -112,13 +112,13 @@ jobs:
run: echo ARTIFACTS_DIR="${{ github.workspace }}/lambda_artifacts" >> $GITHUB_ENV

- name: Download Lambda Layer and Function artifacts for E2E Test
if: ${{ github.event.inputs.CALLER_WORKFLOW_NAME != 'appsignals-python-e2e-lambda-canary-test' }}
if: ${{ env.CALLER_WORKFLOW_NAME != 'appsignals-python-e2e-lambda-canary-test' }}
run: |
aws s3 cp s3://${{ env.STAGING_S3_BUCKET }}/layer-${{ github.run_id }}.zip ${{ env.ARTIFACTS_DIR }}/layer.zip |
aws s3 cp s3://${{ env.STAGING_S3_BUCKET }}/function-${{ github.run_id }}.zip ${{ env.ARTIFACTS_DIR }}/pyfunction.zip

- name: Set Canary Environment Variable
if: ${{ github.event.inputs.CALLER_WORKFLOW_NAME == 'appsignals-python-e2e-lambda-canary-test' }}
if: ${{ env.CALLER_WORKFLOW_NAME == 'appsignals-python-e2e-lambda-canary-test' }}
run: |
echo IS_CANARY=true >> $GITHUB_ENV |
aws s3 cp {{ env.SAMPLE_APP_ZIP }} ${{ env.ARTIFACTS_DIR }}/pyfunction.zip
Expand Down