Skip to content

Conversation

@pxaws
Copy link
Member

@pxaws pxaws commented Oct 23, 2024

Issue description:

Description of changes:

  • update the node ec2 default workflow to accept the node version and cpu architecture as inputs (with default values)
  • update the terraform to launch instances with different cpu architecture
  • update the ec2 user data to use different version of node to run the sample app
  • update the trace validation template to accept both ec2 instances (t3.small for x86_64 and t4g.small for arm64)

Rollback procedure:

Revert the change.

Ensure you've run the following tests on your changes and include the link below:

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

Tested the changes with a test workflow yaml file which run the test cases for different node version and cpu architectures. In addition, the existing ec2 default canary is also triggered without specifying the additional inputs. This is used to verify the current changes won't affect existing node ec2 canary. See details in this test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/11484786155

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pxaws pxaws merged commit 58c45c2 into main Oct 23, 2024
1 check passed
@pxaws pxaws deleted the add-node-tests branch October 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants