Skip to content

Conversation

@vastin
Copy link
Contributor

@vastin vastin commented Nov 1, 2024

Description of changes:
Set current .NET SDK release for .NET E2E tests instead of the latest version because the new ADOT .NET SDK release will introduce breaking changes. It will prevent E2E test failures during release process.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@XinRanZhAWS XinRanZhAWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vastin vastin merged commit 51ae3cb into main Nov 1, 2024
1 check passed
@vastin vastin deleted the dotnet-sdk-1_3_2 branch November 1, 2024 18:11
vastin added a commit that referenced this pull request Nov 12, 2024
*Description of changes:*
Set current .NET SDK release for .NET E2E tests instead of the latest
version because the new ADOT .NET SDK release will introduce breaking
changes. It will prevent E2E EKS test failures when new EKS addon (which
will use the new ADOT .NET SDK) is released. It is related to
#310
and
#309.

The EKS addon installation script is updated in `dotnet-sdk-1_3_2`
branch as
aws-observability/application-signals-demo@main...dotnet-sdk-1_3_2.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
AsakerMohd added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants