Set dotnet E2E nuget test target for dotnet sdk v1.3.2 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vastin
added a commit
that referenced
this pull request
Nov 12, 2024
*Description of changes:* Set current .NET SDK release for .NET E2E tests instead of the latest version because the new ADOT .NET SDK release will introduce breaking changes. It will prevent E2E EKS test failures when new EKS addon (which will use the new ADOT .NET SDK) is released. It is related to #310 and #309. The EKS addon installation script is updated in `dotnet-sdk-1_3_2` branch as aws-observability/application-signals-demo@main...dotnet-sdk-1_3_2. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
AsakerMohd
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit f6bc748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Set current .NET SDK release for .NET E2E Nuget instead of the latest version because the new ADOT .NET SDK release will introduce breaking changes. This will fix the current Nuget E2E failure.