Skip to content

Conversation

@Jeel-mehta
Copy link
Contributor

Issue description:

Description of changes: I have dynamically deployed the sample app for both the versions of dotnet support (8.0 and 6.0). I am attaching a link of github workflow where I have tested my code for version 6.0 and 8.0 for the region us-east-1. This specific code change will include and handle both versions for all the regions.

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of looking for the default version '8.0' and replacing it, you should change wherever it says 8.0 to {{DOTNET_VERSION}} and use sed commands to replace all of the occurrences of that string

@Jeel-mehta Jeel-mehta force-pushed the Dotnet-sample-app-deploy branch from 5e7a365 to f50c6b5 Compare December 27, 2024 19:01
@Jeel-mehta
Copy link
Contributor Author

requested change

Hey Mahad, I think if we have a dynamic variable {{DOTNET_VERSION}} instead of 8.0, we are just handling the csproj files currently(frontend and remote service). Right now we are not considering Dockerfiles, but since Dockerfiles and csproj files are important when it comes to eks clusters at that time they won't be uniform. Also while working with eks clusters, the Dockerfiles call csproj files and since they will not be uniform, it will throw an error.

@Jeel-mehta Jeel-mehta merged commit ce9f67c into aws-observability:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants