Skip to content

Conversation

@wangzlei
Copy link
Contributor

@wangzlei wangzlei commented Jan 3, 2025

Issue description:
When searching the trace by API GetTraceSummaries, if the end time of searching is set to be far away from the actual trace end time, xray does not return Lambda traces. Right now I am not sure it is an aws sdk xray client issue or xray service issue. This PR is a workaround by moving trace validation step to be earlier, so the endTime of searching, which the value is the current time, is close to the actual trace end time. Then xray service can return the Lambda trace and pass the trace validation.

Description of changes:

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wangzlei wangzlei merged commit b384fcf into aws-observability:main Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants