Skip to content

Conversation

@Jeel-mehta
Copy link
Contributor

@Jeel-mehta Jeel-mehta commented Jan 7, 2025

Issue description:

Description of changes: I have made several changes to accommodate the dynamic version handling for dotnet support. This will check the e2e EC2 test for both versions for all regions. I am attaching a link that reflects the same changes on my repository and with the region us-east-1. Here is the link: https://github.com/Jeel-mehta/aws-application-signals-test-framework/actions/runs/12680003555

Rollback procedure:

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:

To do so, create a test.yml file with name: Test and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a more recent test run to prove it works, try recreating your branch on the main repo and running the test by calling the workflow on your branch.

@Jeel-mehta
Copy link
Contributor Author

Need a more recent test run to prove it works, try recreating your branch on the main repo and running the test by calling the workflow on your branch.

I have updated the link with the dry run on a different branch and also made the changes in that branch which were suggested above that started with 'nit',if all looks fine will make another commit for resolving the nit comments under the same pull request

@majanjua-amzn majanjua-amzn merged commit f487867 into aws-observability:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants