Skip to content

Conversation

@srprash
Copy link
Contributor

@srprash srprash commented Jan 10, 2025

Issue description: Run E2E test for Application Signals Java Lambda support

Description of changes:

  • Github workflows:
    • Java Lambda Canary - Should be disabled since we haven't released the layers yet.
    • Java Lambda Test - Actual E2E test workflow that is called by the canary or the main build of the ADOT Java repo
    • Java Sample App S3 Deploy - Updated to also uplaod the Java sample app for Lambda testing
  • Terraform files - To deploy the APIGW-Lambda integration sample app for E2E testing.
  • Validation templates for validating trace, EMF Logs, and Application Signals metrics data.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash marked this pull request as ready for review January 12, 2025 22:57
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workfow looks good to me. Just to double check that do we have the Layer ARN ready in those regionalized release accounts? Otherwise the canaries test won't work

@srprash
Copy link
Contributor Author

srprash commented Jan 14, 2025

Good point. We don't have the java layers yet. I will disable the canaries for now.

@srprash srprash merged commit e4958f4 into main Jan 14, 2025
1 check passed
@srprash srprash deleted the java_lambda_test branch January 14, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants