Add ubuntu test, terraform and validation files #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validator/src/main/resources/validations/java/ec2/ubuntu/log-validation.yml
Outdated
Show resolved
Hide resolved
majanjua-amzn
requested changes
Jan 27, 2025
There was a problem hiding this comment.
I believe your test run is running either the wrong validation or the wrong test entirely. Please rerun and ensure the testing is done correctly.
With your current changes, it's impossible for it to be testing your changes as you are missing essential configurations.
validator/src/main/resources/validations/java/ec2/ubuntu/log-validation.yml
Outdated
Show resolved
Hide resolved
majanjua-amzn
requested changes
Jan 27, 2025
validator/src/main/java/com/amazon/aoc/fileconfigs/PredefinedExpectedTemplate.java
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/java/ec2/ubuntu/log-validation.yml
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/java/ec2/ubuntu/log-validation.yml
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/java/ec2/ubuntu/metric-validation.yml
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/java/ec2/ubuntu/trace-validation.yml
Outdated
Show resolved
Hide resolved
added 2 commits
January 27, 2025 16:23
majanjua-amzn
approved these changes
Jan 28, 2025
I have edited the PR with new test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description: Existing testing framework did not have ubuntu test for java
Description of changes: Added java ec2 ubuntu test along with terraform files and validation files
Test link: https://github.com/Jeel-mehta/aws-application-signals-test-framework/actions/runs/13001021774
Rollback procedure:
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.