Pin @aws-sdk/client-s3 to 3.621.0 for Sample App to support Node.js 14 #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Main Builds for ADOT JS are failing recently: https://github.com/aws-observability/aws-otel-js-instrumentation/actions/workflows/main-build.yml
AWS SDK stopped supporting Node 14 recently
We use ^3.621.0 in the sample app used for testing, I tested the sample app uses a version that does not work in Node 14 after
npm install.Description of changes:
In the future, we can revert this change after Node.js 14 support is dropped.
Rollback procedure:
Revert this PR, which is a safe change.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.