Skip to content

Rename service name #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Rename service name #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70bc5a1
Shorten remote deployment names
pxaws Feb 14, 2025
0e97069
test java eks
pxaws Feb 14, 2025
d668478
test python eks
pxaws Feb 14, 2025
5af1c77
test node eks
pxaws Feb 14, 2025
33230e4
test dotnet eks
pxaws Feb 14, 2025
c43340e
remove test workflows
pxaws Feb 14, 2025
e61403c
remove k8s changes
pxaws Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/dotnet/eks/linux/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ resource "kubernetes_service" "dotnet_app_service" {
resource "kubernetes_deployment" "dotnet_r_app_deployment" {

metadata {
name = "dotnet-r-app-deployment-${var.test_id}"
name = "dotnet-remote-${var.test_id}"
namespace = var.test_namespace
labels = {
app = "remote-app"
Expand Down
2 changes: 1 addition & 1 deletion terraform/java/eks-otlp-ocb/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ resource "kubernetes_service" "sample_app_service" {
resource "kubernetes_deployment" "sample_remote_app_deployment" {

metadata {
name = "sample-r-app-deployment-${var.test_id}"
name = "sample-remote-${var.test_id}"
namespace = var.test_namespace
labels = {
app = "remote-app"
Expand Down
9 changes: 6 additions & 3 deletions terraform/java/eks/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,14 @@ resource "kubernetes_deployment" "sample_remote_app_deployment" {
}
}

resource "kubernetes_service" "sample_remote_app_service" {
resource "kubernetes_service" "sample_remote_app_deployment" {
depends_on = [ kubernetes_deployment.sample_remote_app_deployment ]

metadata {
name = "sample-remote-app-service"
# use the same name as the deployment to handle the edge case when the deployment name is longer than 47 characters
# in this edge case, we just use the service name (rather than deployment name) as RemoteService
# see https://github.com/aws/amazon-cloudwatch-agent/pull/1553
name = "sample-r-app-deployment-${var.test_id}"
namespace = var.test_namespace
}
spec {
Expand Down Expand Up @@ -260,4 +263,4 @@ resource "kubernetes_deployment" "traffic_generator" {
}
}
}
}
}
2 changes: 1 addition & 1 deletion terraform/node/eks/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ resource "kubernetes_service" "sample_app_service" {
resource "kubernetes_deployment" "sample_remote_app_deployment" {

metadata {
name = "sample-r-app-deployment-${var.test_id}"
name = "sample-remote-${var.test_id}"
namespace = var.test_namespace
labels = {
app = "remote-app"
Expand Down
2 changes: 1 addition & 1 deletion terraform/python/eks/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ resource "kubernetes_service" "python_app_service" {
resource "kubernetes_deployment" "python_r_app_deployment" {

metadata {
name = "python-r-app-deployment-${var.test_id}"
name = "python-remote-${var.test_id}"
namespace = var.test_namespace
labels = {
app = "remote-app"
Expand Down