[Node] Add ADOT SigV4 Release Test #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
added
enhancement
harrryr
reviewed
Mar 19, 2025
harrryr
approved these changes
Mar 19, 2025
liustve
pushed a commit
that referenced
this pull request
Mar 20, 2025
majanjua-amzn
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Mar 20, 2025
Follow up to: [aws-observability/aws-application-signals-test-framework #379](aws-observability/aws-application-signals-test-framework#379) By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We recently added the ADOT SigV4 exporter to the aws-otel-js-instrumentation repo that allows users to export spans directly the the X-Ray OTLP endpoint from their application instead of relying on a collector or agent.
Changes
Added workflow, terraform definitions, and validations
Notable differences in behaviour between JS and other languages for this use case
span.namealways seems to beGETinstead ofGET apiorGET /apiresource.attributes.["aws.local.service"]is missing for all APIsattributes.["aws.region"]is missing for/aws-sdk-callAPI (resource.attributes.["cloud.region"]is still present)Rollback Procedure
Revert
Testing
Successful run: link
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.