generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 23
[Java] Add ADOT SigV4 Release Test #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
Mar 26, 2025
liustve
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Mar 26, 2025
Follow up to: aws-observability/aws-application-signals-test-framework#381 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We recently added the ADOT SigV4 exporter to the aws-otel-java-instrumentation repo that allows users to export spans directly the the X-Ray OTLP endpoint from their application instead of relying on a collector or agent.
Changes
Added workflow, terraform definitions, and validations
Notable differences in behaviour between Java and other languages for this use case
See Trace validation modifications commit under validator/src/main/resources/java/ec2/adot-sigv4. Differences are not limited to this commit, as the differences in logs were in the first commit.
"service.name","cloud.provider", "cloud.region", "cloud.account.id", "cloud.platform"Are missing from attributes (aws.local.serviceappears if AppSignals is enabled.)Any mention ofec2has been replaced bygenerichttp.methodis nowhttp.request.methodhttp.urlhas been separated intourl.scheme,server.address,url.path,url.query. Sometimes it's justurl.fullhttp.request.urlandsubsegments[0].http.request.urlare both missing. This causes theURL Addressfield in the X-Ray console to be blank (from what I can tell)Rollback Procedure
Revert
Testing
Successful run: link
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.