Skip to content

Conversation

@liustve
Copy link
Contributor

@liustve liustve commented Mar 24, 2025

Background

We recently added the ADOT SigV4 exporter to the aws-otel-java-instrumentation repo that allows users to export spans directly the the X-Ray OTLP endpoint from their application instead of relying on a collector or agent.

Changes

Added workflow, terraform definitions, and validations

Notable differences in behaviour between Java and other languages for this use case

See Trace validation modifications commit under validator/src/main/resources/java/ec2/adot-sigv4. Differences are not limited to this commit, as the differences in logs were in the first commit.

  • [LOG/TRACE] "aws.local.service" "service.name","cloud.provider", "cloud.region", "cloud.account.id", "cloud.platform" Are missing from attributes (aws.local.service appears if AppSignals is enabled.)
  • [LOG/TRACE/METRICS] Any mention of ec2 has been replaced by generic
  • [LOG/TRACE] http.method is now http.request.method
  • [LOG/TRACE] http.url has been separated into url.scheme, server.address, url.path, url.query. Sometimes it's just url.full
  • [TRACE] http.request.url and subsegments[0].http.request.url are both missing. This causes the URL Address field in the X-Ray console to be blank (from what I can tell)

Rollback Procedure

Revert

Testing

Successful run: link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liustve liustve merged commit b0acba6 into main Mar 26, 2025
1 check passed
@liustve liustve deleted the java-sigv4 branch March 26, 2025 18:38
liustve added a commit to aws-observability/aws-otel-java-instrumentation that referenced this pull request Mar 26, 2025
Follow up to:
aws-observability/aws-application-signals-test-framework#381

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants