Skip to content

Conversation

@thpierce
Copy link
Contributor

@thpierce thpierce commented May 8, 2025

Issue description:

We have a hard dependency on the aws-appsignals-sample-app-prod-region bucket, which made running anything in personal repos impossible.

Description of changes:
Replace all references to bucket with input (with default). Also disables fail-fast in traffic-generator-image-build.yml, which was another thing that would fail in personal repos.

Rollback procedure:

Simple revert.

Ensure you've run the following tests on your changes and include the link below:

Tested:

Not tested (not impacted by changes)

  • Unrelated workflows/no relevant S3 usage:
    • appsignals-e2e-gamma-test.yml
    • dummy-k8s-test.yml
    • enablement-test-publish-result.yml
    • k8s-patch-os-jobs.yml
    • k8s-patch-os-matrix.yml
    • pr-build.yml
  • EKS/ECR tests don't use S3 bucket:
    • dotnet-eks-test.yml
    • dotnet-eks-windows-test.yml
    • dotnet-sample-app-ecr-deploy.yml
    • java-ecs-test.yml
    • java-eks-otlp-ocb-canary.yml
    • java-eks-otlp-ocb-retry.yml
    • java-eks-otlp-ocb-test.yml
    • java-eks-test.yml
    • java-sample-app-ecr-deploy.yml
    • node-ecs-test.yml
    • node-eks-test.yml
    • metric-limiter-test.yml
    • node-sample-app-ecr-deploy.yml
    • python-ecs-test.yml
    • python-eks-test.yml
    • python-sample-app-ecr-deploy.yml
  • Lambda perf tests don't use S3 bucket:
    • dotnet-lambda-layer-perf-test.yml
    • java-lambda-layer-perf-test.yml
    • node-lambda-layer-perf-test.yml
    • python-lambda-layer-perf-test.yml
  • Uses a different S3 bucket (or possibly the same? Need to look at secret val)
    • node-sample-app-s3-deploy.yml
    • python-sample-app-s3-deploy.yml
    • resource-cleanup.yml

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.

  • Run Java EKS on e2e-playground in us-east-1 and eu-central-2
  • Run Python EKS on e2e-playground in us-east-1 and eu-central-2
  • Run metric limiter on EKS cluster e2e-playground in us-east-1 and eu-central-2
  • Run EC2 tests in all regions
  • Run K8s on a separate K8s cluster (check IAD test account for master node endpoints; these will change as we create and destroy clusters for OS patching)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thpierce thpierce closed this May 9, 2025
@thpierce thpierce deleted the resource-attributes branch May 9, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant