Add resource copy test validation #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
added a commit
to aws/amazon-cloudwatch-agent
that referenced
this pull request
May 9, 2025
majanjua-amzn
approved these changes
May 13, 2025
validator/src/main/resources/expected-data-template/java/ec2/default/aws-sdk-call-log.mustache
Show resolved
Hide resolved
|
CWAgent released to all commercial regions, this should be safe to merge. |
thpierce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
We recently added logic to CWA to support copying resource attributes to exported EMF records, so we need to validate this logic.
Description of changes:
Update two tests (changes are not language- or platform- dependent) to specify resource attribute that triggers copy logic in CWA. Update validators to assert behaviour is as expected (resource attributes show up in EMF logs).
Rollback procedure:
We can safely revert this commit if needed.
Ensure you've run the following tests on your changes and include the link below:
Testing from CWA repo, since changes are merged but not released:
resource-attributesresource-attributes- DONEBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.