-
Notifications
You must be signed in to change notification settings - Fork 23
[Python] SigV4 logs release testing #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a high level comment: I think we should refrain from using the term SigV4 for these validations. Sigv4 is just an auth mechanism and an internal functionality of the ADOT SDK. It does not appear anywhere in the user application code or the telemetry produced.
See if you can find time to refactor the old code that references sigv4 in these testing. 🙂
validator/src/main/java/com/amazon/aoc/fileconfigs/PredefinedExpectedTemplate.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWLogValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWLogValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/python/ec2/adot-sigv4/logs/log-validation.yml
Outdated
Show resolved
Hide resolved
f13400e to
00c2fee
Compare
00c2fee to
6efad38
Compare
|
Is this PR still a draft? Anyway, the changes look good to me so I've approved. You can resolve the comments, change from draft, and merge when ready. Thank you. |
Issue description:
Need to implement and validate SigV4 log functionality for Python EC2 ADOT (Stand-Alone ADOT) use case. The primary focus is on validating logs sent to the otlp_logs log group using a consistent and reliable approach that can be replicated across different language implementations.
Description of changes:
Updated Terraform configuration:
Added validation resources:
Workflow Updates:
Rollback procedure:
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/15149888024/job/42593928321
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.