generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 23
[Java] SigV4 logs release testing #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
reviewed
Jun 5, 2025
harrryr
reviewed
Jun 5, 2025
validator/src/main/java/com/amazon/aoc/fileconfigs/PredefinedExpectedTemplate.java
Outdated
Show resolved
Hide resolved
harrryr
reviewed
Jun 5, 2025
validator/src/main/resources/expected-data-template/java/ec2/adot-aws-otlp/logs/log.mustache
Show resolved
Hide resolved
harrryr
reviewed
Jun 5, 2025
validator/src/main/resources/validations/java/ec2/adot-aws-otlp/logs/log-validation.yml
Show resolved
Hide resolved
96ba235 to
8956518
Compare
harrryr
approved these changes
Jun 7, 2025
...c/main/resources/expected-data-template/java/ec2/adot-aws-otlp/logs/application-log.mustache
Show resolved
Hide resolved
...or/src/main/resources/validations/java/ec2/adot-aws-otlp/logs/application-log-validation.yml
Show resolved
Hide resolved
majanjua-amzn
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
This PR implements and validates SigV4 log functionality for Java EC2 ADOT (Stand-Alone ADOT) use case. The implementation focuses on validating logs sent to the
otlp_logslog group, ensuring a consistent and reliable validation approach that can be replicated across different language implementations.Description of changes:
Rollback procedure:
Test run- For Java
Also Validating for Python as the filter pattern was changed in the CWLogValidator.java
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.