Skip to content

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Jun 18, 2025

What does this pull request do?

Updates our EC2 and EKS workflows to build Python 3.13 so our main build stops failing adding support for this runtime version in ADOT Python.

We can safely revert these changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about python S3 deployment? I only see the python-sample-app-ecr-deploy file was updated.

Edit: Nvm, I see it's updated in the ec2 related workflows, ty

Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiyuan-he yiyuan-he merged commit 2dc7c2c into aws-observability:main Jun 18, 2025
1 check passed
@yiyuan-he yiyuan-he deleted the add-3.13-support branch June 18, 2025 16:46
yiyuan-he added a commit that referenced this pull request Jun 18, 2025
## What does this pull request do?
Missed adding Python 3.13 support in one part of the EC2 workflow:
#415

This should fix the EC2 failure in [main
build](https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/15741464564/job/44371235567).

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants