-
Notifications
You must be signed in to change notification settings - Fork 23
Replace Console with bunyan logger in Sample App #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run these sample applications with a custom built ADOT JS artifact from mainline and validate that the logs appear in your expected dev account's log group and update your PR description with screenshots of it?
60881b5 to
b545aaa
Compare
|
Issue description:
There are currently no OTel supported logs being emitted from the sample-app.
Description of changes:
Replaced console.log statements with Bunyan logging library throughout the application
Added Bunyan dependency (^1.8.15) to package.json
Implemented structured logging with consistent format across all endpoints
Updated the following files:
This is similar to [PR [#186]] from ADOT JS repository
Testing:
Testing:
Tested locally using docker-compose:
Built and ran both frontend and remote services successfully
Verified all endpoints working as expected:
Verified Bunyan structured logs appearing correctly for both services:
All endpoints tested using curl commands against localhost:8000 and localhost:8001.
Services started and stopped successfully using docker-compose up/down.
I am attaching two screenshots for reference of my testing:


Also I tested the updated sample app after adot js instrumentation to see if I receive logs in my personal cloudwatch account. Here are the screenshots for the logs received


Rollback procedure:
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.