generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 23
[Bedrock AgentCore] Release Testing - Validator Changes #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
11a9f57
add validator changes
liustve 9c6ae0b
fix nullpointer with httpPath
liustve c8f0a00
test
liustve 4652a05
test
liustve 0c6e21c
test
liustve 4b90f03
test
liustve 9383817
test
liustve 07cdb86
remove test
liustve ae1d62e
add null check
liustve File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
validator/src/main/resources/expected-data-template/python/ec2/adot-genai/genai-log.mustache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| [{ | ||
| "resource": { | ||
| "attributes": { | ||
| "aws.local.service": "{{serviceName}}", | ||
| "aws.service.type": "gen_ai_agent", | ||
| "service.name": "{{serviceName}}" | ||
| } | ||
| }, | ||
| "scope": { | ||
| "name": "openinference.instrumentation.langchain" | ||
| }, | ||
| "severityNumber": "^[0-9]+$", | ||
| "severityText": ".*", | ||
| "body": { | ||
| "output": { | ||
| "messages": [ | ||
| { | ||
| "content": "^.+$", | ||
| "role": "assistant" | ||
| } | ||
| ] | ||
| }, | ||
| "input": { | ||
| "messages": [ | ||
| { | ||
| "content": "^.+$", | ||
| "role": "user" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "attributes": { | ||
| "event.name": "openinference.instrumentation.langchain" | ||
| }, | ||
| "traceId": "{{traceId}}" | ||
| }] |
4 changes: 4 additions & 0 deletions
4
...tor/src/main/resources/expected-data-template/python/ec2/adot-genai/genai-metric.mustache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| - | ||
| metricName: ANY_VALUE | ||
| namespace: {{metricNamespace}} | ||
| dimensions: [] |
20 changes: 20 additions & 0 deletions
20
...ator/src/main/resources/expected-data-template/python/ec2/adot-genai/genai-trace.mustache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [{ | ||
| "name": "^{{serviceName}}$", | ||
| "trace_id": "^{{traceId}}$", | ||
| "http": { | ||
| "request": { | ||
| "url": "^.*/ai-chat$", | ||
| "method": "^POST$" | ||
| } | ||
| }, | ||
| "aws": { | ||
| "service.type": "^gen_ai_agent$" | ||
| }, | ||
| "annotations": { | ||
| "aws.local.service": "^{{serviceName}}$", | ||
| "aws.local.operation": "^POST /ai-chat$" | ||
| }, | ||
| "metadata": { | ||
| "service.name": "^{{serviceName}}$" | ||
| } | ||
| }] |
6 changes: 6 additions & 0 deletions
6
validator/src/main/resources/validations/python/ec2/adot-genai/log-validation.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| - | ||
| validationType: "cw-log" | ||
| httpPath: "ai-chat" | ||
| httpMethod: "post" | ||
| callingType: "http" | ||
| expectedLogStructureTemplate: "PYTHON_EC2_ADOT_GENAI_LOG" |
6 changes: 6 additions & 0 deletions
6
validator/src/main/resources/validations/python/ec2/adot-genai/metric-validation.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| - | ||
| validationType: "cw-metric" | ||
| httpPath: "ai-chat" | ||
| httpMethod: "post" | ||
| callingType: "http" | ||
| expectedMetricTemplate: "PYTHON_EC2_ADOT_GENAI_METRIC" |
6 changes: 6 additions & 0 deletions
6
validator/src/main/resources/validations/python/ec2/adot-genai/trace-validation.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| - | ||
| validationType: "trace" | ||
| httpPath: "ai-chat" | ||
| httpMethod: "post" | ||
| callingType: "http" | ||
| expectedTraceTemplate: "PYTHON_EC2_ADOT_GENAI_TRACE" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.