Remove internal span validation from OCB test #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, there was a minor backend change that (correctly) set aws.local.environment for all span types (previously only server/client). This caused this workflow to fail: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16662392099/job/47162204198: ``` 23:57:12.295 [main] ERROR com.amazon.aoc.validators.TraceValidator - Data model validation failed 23:57:12.295 [main] INFO com.amazon.aoc.validators.TraceValidator - Mismatched data model field list 23:57:12.295 [main] INFO com.amazon.aoc.validators.TraceValidator - Mismatched data for key: [1].subsegments[0].annotations[\"aws.local.environment\"] 23:57:12.295 [main] INFO com.amazon.aoc.validators.TraceValidator - Value of stored trace map: ^eks:e2e-java-otlp-ocb-canary-test/ns-16662392099-11037$ 23:57:12.295 [main] INFO com.amazon.aoc.validators.TraceValidator - Value of retrieved map: generic:default ``` In this test, we are sending spans to X-Ray OTLP Endpoint, who will modify the spans for the purposes of generating ApplicationSignals. This test was validating incorrect behaviour and after some discussion, we felt that it was validating behaviour that is not really relevant to the test itself. To prevent future test failures, we are removing this part of the test validation logic.
majanjua-amzn
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Recently, there was a minor backend change that (correctly) set aws.local.environment for all span types (previously only server/client). This caused this workflow to fail: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16662392099/job/47162204198:
Description of changes:
In this test, we are sending spans to X-Ray OTLP Endpoint, who will modify the spans for the purposes of generating ApplicationSignals. This test was validating incorrect behaviour and after some discussion, we felt that it was validating behaviour that is not really relevant to the test itself. To prevent future test failures, we are removing this part of the test validation logic.
Rollback procedure:
Can we safely revert this commit if needed? Yes.
Ensure you've run the following tests on your changes and include the link below:
Tested here: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16920194765
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.